feat(angular-mcp-server): add violation grouping tool #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poltorak
approved these changes
Nov 25, 2025
...ular-mcp-server/src/lib/tools/ds/component-contract/builder/build-component-contract.tool.ts
Outdated
Show resolved
Hide resolved
.../angular-mcp-server/src/lib/tools/ds/component-contract/diff/diff-component-contract.tool.ts
Outdated
Show resolved
Hide resolved
|
|
||
| return `# ${group.name} | ||
| ## Summary |
AdrianRomanski
requested changes
Nov 25, 2025
Member
AdrianRomanski
left a comment
AdrianRomanski
left a comment
There was a problem hiding this comment.
Overall it looks solid, but i dont like the "/" comments before initalization of variables.
They add nothing to the context more than method would do.
/** comments are good
...ular-mcp-server/src/lib/tools/ds/component-contract/builder/build-component-contract.tool.ts
Outdated
Show resolved
Hide resolved
packages/angular-mcp-server/src/lib/tools/ds/report-violations/group-violations.tool.ts
Show resolved
Hide resolved
packages/angular-mcp-server/src/lib/tools/ds/report-violations/utils/work-group.utils.ts
Outdated
Show resolved
Hide resolved
packages/angular-mcp-server/src/lib/tools/ds/report-violations/utils/format-converter.utils.ts
Outdated
Show resolved
Hide resolved
rapczynska
requested changes
Nov 25, 2025
...ular-mcp-server/src/lib/tools/ds/component-contract/builder/build-component-contract.tool.ts
Outdated
Show resolved
Hide resolved
| 'Path where to save the diff result file. Supports both absolute and relative paths.', | ||
| 'Path where to save the diff result file. Supports both absolute and relative paths. If not provided, defaults to tmp/.angular-toolkit-mcp/contracts/diffs/<component-name>-diff.json', | ||
| }, | ||
| contractBeforePath: { |
Collaborator
There was a problem hiding this comment.
Contract diff has a default saveLocation path, would be good to have an unified approach to provide same default location for contractBefore-*/afterPath
Member
Author
There was a problem hiding this comment.
I improved schemas, but not sure we want to have explicit before/after folders.
packages/angular-mcp-server/src/lib/tools/ds/report-violations/group-violations.tool.ts
Outdated
Show resolved
Hide resolved
packages/angular-mcp-server/src/lib/tools/ds/report-violations/utils/index.ts
Show resolved
Hide resolved
…at and improving file conversion logic
…t path resolution and update related handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the Angular MCP toolkit, specifically around reporting and organizing deprecated CSS violations. The main improvements include a new tool for distributing violations into balanced work groups, improved documentation, and better default file handling for component contract tools. These changes streamline large-scale migration workflows and make the toolkit easier to use and integrate.
New Violation Grouping Tool & Workflow Improvements
New tool for work distribution:
group-violationstool, which takes a saved violations report and organizes files into balanced work groups using a bin-packing algorithm. It ensures path exclusivity and maintains directory boundaries for parallel development, saving results as individual JSON and Markdown files. [1] [2] [3] [4]Documentation updates:
README.mdanddocs/tools.mdto describe the newgroup-violationstool, clarify the purpose and output ofreport-violationsandreport-all-violations, and revise recommended workflows to include group creation for parallel migration. [1] [2] [3] [4]Component Contract Tool Improvements
Default save location handling:
saveLocationto be optional in both the build and diff component contract tools. If not provided, a sensible default path is generated based on the component name, reducing required configuration and avoiding errors. [1] [2] [3] [4] [5] [6]Schema updates:
saveLocationis now optional and documented the new default path behavior. [1] [2] [3] [4]These changes make it easier to run large-scale migrations by automating the grouping of work, improving documentation, and simplifying file management for contract tools.